Feat/api keys #122
Merged
Feat/api keys #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
dosubot
bot
added
size:L
csgulati09
reviewed
Oct 7, 2024
src/apis/apiKeys.ts
Outdated
| last_updated_at?: Date; | ||
| creation_mode?: string; | ||
| rate_limits?: Record<string, unknown>[]; | ||
| usage_limits?: Record<string, unknown>; |
There was a problem hiding this comment.
Record of the type string, any or it has to be unknown?
There was a problem hiding this comment.
Also check for the same in the other interfaces as well
src/apis/apiKeys.ts
Outdated
| id?: string; | ||
| } | ||
|
|
||
| function toQueryParams(params?: ApiKeysListParams): string { |
There was a problem hiding this comment.
Extract this function of utils.ts
csgulati09
previously approved these changes
Oct 9, 2024
csgulati09
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api-keys API added
Description:
Related Issues:
#121